Compilation info #87
Closed
Compilation info #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename of attachment descriptor types. - Rename of attachment descriptors .attachment -> .view - Rename of BlendFactors - Rename of SetBlendColor to SetBlendConstant
kvark
approved these changes
Apr 21, 2021
|
Yes, making it extensible sounds reasonable. |
|
Also maybe for WGPUCompilationMessage. @toji WDYT? |
toji
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
LGTM. And yes, it's probably a decent idea for at least CompilationInfo to be extensible. Feels like making CompilationMessage extensible may just be unnecessary complexity. If worst comes to worst you could always add a parallel array to CompilationInfo to contain additional per-message data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL!
Do you think that
WGPUCompilationInfoshould be extensible so that the WebGPU library can pass more information to the application in the future?